ForkAwesome / Fork-Awesome

A fork of the iconic font and CSS toolkit
https://forkaweso.me
1.32k stars 138 forks source link

Icon Set Request: icon-shutter #66

Open nioc opened 6 years ago

nioc commented 6 years ago

Hello, is it possible to add a shutter icon like this one: FortAwesome/Font-Awesome#6392 I would like to add some icons to a photo gallery website :) By the way, there is a set of camera related icons, do you prefer one issue for each (see here FortAwesome/Font-Awesome#4508) or this one handle the set? The wished icons:

xuv commented 6 years ago

Hey @nioc, that's a good question. And I really like the request. In this case, since it's concersn a whole iscon set around a certain topic, then I would say to use the same issue. But an opinion from @tessus and @micahilbery here would be nice.

One thing though. If you submit any design proposal for these icons, please mention if you drew this yourself or if you found it somewhere.

Thanks.

tessus commented 6 years ago

Using one issue for an icon set is not a bad idea.

However, I'd implement the following changes:

Also, we should define a naming convention: e.g.: fa-ICONSET-ICONNAME

I don't know, maybe in some cases it makes sense not to use the iconset in the fa- name This is maybe a point for a more detailed discussion.


Regarding this request:

is it possible to add a shutter icon like this one: FortAwesome/Font-Awesome#6392

This image is ok to be used as a template.

see here FortAwesome/Font-Awesome#4508

I don't think that the quality is good enough to create icons from this, but I can be wrong.

In any case, all the requested icons should be added to this ticket as images.

nioc commented 6 years ago

Hello, ok good news :) I'll update the issue with your advice. For the images, I can try to make a draft on Inkscape for the missing ones. If someone with real design skills want to increase its it would be perfect.

tessus commented 6 years ago

Sounds great. I'm not very experienced in creating icons yet, but I'm workign on it. ;-) In the meantime, I'm sure that @xuv and @micahilbery can help out when you run into any issues.

nioc commented 6 years ago

In this archive, there is my first try with aperture, shutter/timer, ISO and focal length icons, feel free to optimize :smile: g4193. Let me know if the format is correct for you, I'll add the missing one(s).

tessus commented 6 years ago

wow, these icons look great.

@xuv do you think we can add them to the 1.1.0 release? what about a naming convention? e.g. just fa-* vs fa-camera-* vs fa-photo-*

haufe commented 6 years ago

I'm here for the "fa-shutter" - the longer i look at it, the better i like it!

The timer is a bit similar to the "fa-stopwatch".

About "fa-iso" and "fa-aperture" (?) i have no feelings.

tessus commented 6 years ago

@xuv ping. do you think we can add them to the 1.1.0 release? what about a naming convention? e.g. just fa-* vs fa-camera-* vs fa-photo-*

micahilbery commented 6 years ago

If fa-stopwatch is really similar and could convey the correct meaning depending on the context then we could just alias it.

xuv commented 6 years ago

Hey... I don't mind adding them to 1.1. Though I have questions about the timer and and iso one.

Timer or fa-stopwatch makes me think a lot about the clock. Is it a repetition? Should there be 2 different icons? If yes, could we maybe keep the same style for both?

ISO is puzzling because although this is usually the icon we find in cameras, it does not really work as an icon like the others... Is there any way we could make this more graphical?

xuv commented 6 years ago

PS: I don't see fa-stopwatch in our icon set. Font Awesome 5 has it. But Fork Awesome does not.

xuv commented 6 years ago

@tessus About the naming convention, I would try to keep the model set by Fort Awesome. I think the logic is not to make sets in the naming since icons could be used in different sets. A stopwatch for example could be used in many contexts.

Now, we could definitely make a set in the documentation that regroups camera or image recording capabilities for easier searching.

tessus commented 6 years ago

@xuv

icons could be used in different sets

good point.

vNow, we could definitely make a set in the documentation that regroups camera or image recording capabilities for easier searching.

This is a good idea, but I guess it would be a lot of work, if this had to be done manually for every Icon set.

xuv commented 6 years ago

@tessus: It's "manually" done by adding a category under each relevant icon in the src/icons/_icons.yml file... Then I think we just have to add it to the jekyll templates to diplay it in the docs...

tessus commented 6 years ago

@xuv awesome that's easy then

tessus commented 5 years ago

what's the status on this one?