search

ForkGG / Fork-legacy

Fork: Minecraft Server Manager GUI for Windows
https://www.fork.gg
MIT License
102 stars 15 forks source link

Update SpigotWebRequester.cs #41

Closed KarmaDeb closed 8 months ago

KarmaDeb commented 8 months ago

Added support back to spigot, without depending on serverjars.

As serverjars dropped support for SpigotMC, I decied to use BuildTools technique to fetch versions, and then after having all the versions, simply make a download request to getbukkit.org

A new library has been needed in the process, HtmlAgilityPack

PenguCCN commented 8 months ago

I actually have a pending pull for updating Fork. We're waiting on some icons to be designed since I added support for new server versions. We actually chose to deprecate Spigot support since tbh nobody should be using it as server software.

KarmaDeb commented 8 months ago

I actually have a pending pull for updating Fork. We're waiting on some icons to be designed since I added support for new server versions. We actually chose to deprecate Spigot support since tbh nobody should be using it as server software.

I don't think spigot should not be used as a server software. It's right (and a fact) that other alternatives such as Paper or Purpur are simply faster, but has been also tested that some spigot plugins don't work as expected in Paper or don't even work on Purpur because the modifications they've done to them.

You could of course simply use paper only plugins, but there're not as many as spigot plugins.

ChristianKernDev commented 8 months ago

I actually agree with @KarmaDeb, because it can't hurt to support more types of servers. I will merge this PR and try to merge the changes to the PR of @PenguCCN. Will try to build a new beta release until the weekend