Spigot version downloads and locally installed plugins

[KarmaDeb]

IMPORTANT NUGET REQUIRED

• Because of how the requests are made for spigot versions, in where a directory list must be read, I've been required of HtmlAgilityPack, which can be installed from NuGet
• Because of locally installed plugins, I've also required of SharpZipLib in order to read locally installed plugin name

I've noticed on my last pull request, which fixed SpigotMC version support, that older versions were not downloading. That was because apparently, the method I used to download them is only "compatible" with newer versions.

Even though old versions shouldn't be used anymore, there's still people who uses and requires them, because of nostalgia, or old plugin compatibility which have not been updated yet. Anyway, I've fixed it by download from the bukkit cdn instead of getbukkit.org directly.

I've also added the possibility to install plugins locally and manage them from Fork, NOTE: I haven't tested what happens if you install a plugin remotely and then the same plugin from the spiget API

I think it would also be good if we added a warning message when using legacy versions (should we?)

[ChristianKernDev]

Please also do thorough testing for the local Plugin installation feature and i agree to add a waring message if you use a legacy version

[KarmaDeb]

Please also do thorough testing for the local Plugin installation feature and i agree to add a waring message if you use a legacy version

The only I haven't tested for local plugin installation is what happens when you install the same plugin from spiget (pretty sure you will have two different jars but of the same plugin, in which case spigot (and paper, etc...) choose the most recent version and warn the user about the issue

[KarmaDeb]

I've updated the spigot downloader to download the latest stable versions. For legacy versions (< 1.10.2) that's not possible, as apparently -snapshot was always the latest stable build

[KarmaDeb]

As I expected, installing a Spiget plugin while already having the same local plugin installed will make you to have two plugins

[ChristianKernDev]

Alright thanks a ton! Could you please merge the master Branch from this Repo into your branch, because there are some Merge conflicts because the original spigot Update is already in there

[KarmaDeb]

Alright thanks a ton! Could you please merge the master Branch from this Repo into your branch, because there are some Merge conflicts because the original spigot Update is already in there

I'm having problems to merge 😂 I'll merge in a few minutes

[KarmaDeb]

Fun fact Spigot lost plugins support on the beta (uncommented: Added support for plugins back to spigot)

[KarmaDeb]

I will probably request another pull request later, to make locally installed plugins remove when the spiget plugin gets installed

[ChristianKernDev]

Just let me know once you are finished with this one so i can do a final review and merge. You can also let me know on Discord. I would suggest you create feature-branches in your repo for the PRs so you can work on parallel

[KarmaDeb]

Just let me know once you are finished with this one so i can do a final review and merge. You can also let me know on Discord. I would suggest you create feature-branches in your repo for the PRs so you can work on parallel

Yes, I'm already finished, I'm also on the discord but I can't find you

[ChristianKernDev]

On Discord: IKERNEII

If a user interaction is not doing anything (for example: If a plugin is not installed) it would be nice if a message would be shown or at least in the console of the server