Hostname can be removed?

ForkbombEu / ncr

no‧code‧room: No code REST API server based on zencode natural language smart contracts

4 stars 2 forks source link

Hostname can be removed? #296

Closed matteo-cristino closed 1 week ago

matteo-cristino commented 1 month ago

In this moment the hostname inside the configuration is only used in two part:

to print, as info, where the swagger is running
to create the endpoint the applets will call

I do not think that if we loose the first information it will be a problem (maybe print as default as localhost), for the second point we can use relative urls by removing the hostname and the port to the endpoint the applet will call (we are already using relative url right now, but just for the protocol)

matteo-cristino commented 1 month ago

after #297 now config.hostname is used only to print the swagger page to console