search

FormAlchemy / formalchemy

MIT License
81 stars 29 forks source link

Removed msgfmt #73

Open smurfix opened 3 years ago

smurfix commented 3 years ago

Drop built-in msgfmt

sallner commented 3 years ago

We have now the problem, that this is not building on Python 2. We either stop supporting it right now or you could rewrite it without pathlib. I added some github actions which check the install process. Please rebase this changes on master again.

smurfix commented 3 years ago

I have no problem with not supporting Py2 any more, but that'd require version 1.6.0 IMHO. Probably not a bad idea in any case.

sallner commented 3 years ago

It should then be a 2.0. but it seems, that at least in GHA the installation does not work with Python 3. It seemed to work with tox locally though.

smurfix commented 3 years ago

Yeah, it should, but this isn't the only package that has taken sort of a middle-of-the-road approach on this – as strictly speaking it's not formalchemy that discontinued Py2 support but Python itself.

shasan-beanfield commented 1 year ago

Hi, is it possible to deploy this as a bug fix? We need to be able to install this for upgrading to python 3.8 or above.