Derive Functor from Traversable

FormationAI / dhall-bhat

Tasty meal of Dhall

66 stars 11 forks source link

Closed FintanH closed 6 years ago

zliu41 commented 6 years ago

This has inconsistent type vs Traversable/fromTraverse Maybe call it fromTraversable?

sellout commented 6 years ago

Yeah, I agree with @zliu41’s suggestion – this isn’t just taking the traverse operation, but the Traversable instance.

FintanH commented 6 years ago

Agreed, fixed 👌

zliu41 commented 6 years ago

LGTM