FormationAI / dhall-bhat

Tasty meal of Dhall
66 stars 11 forks source link

Flatten Type Class Structures #14

Closed zliu41 closed 6 years ago

zliu41 commented 6 years ago

Fixes #8

zliu41 commented 6 years ago

@sellout is this the approach you wanted? Another approach is to let Applicative/Type return {ap, pure} only (no map), and use //\\ in all instances, e.g., List/Applicative would return Applicative List //\\ Functor List. But by doing so we need to use a lot more //\\s, including all arguments like λ(applicative : Applicative m) needing to be changed to λ(applicative : Applicative m //\\ Functor m). So I would prefer the current approach, but I wanted to make sure I'm doing the right thing here.

robinbb-takt commented 6 years ago

@sellout It looks like Ziyang might have meant to assign this to you for comment?

coreykanon commented 6 years ago

Old PR before Dhall 1.14. We should trash it or close it out somehow. @zliu41

FintanH commented 6 years ago

@zliu41 I did this over the weekend at https://github.com/FormationAI/dhall-bhat/pull/19

zliu41 commented 6 years ago

👌 nice, haven't been able to get to this for ages.