Add Compactable - Githubissues

FormationAI / dhall-bhat

Tasty meal of Dhall

66 stars 11 forks source link

Add Compactable #55

Open FintanH opened 5 years ago

FintanH commented 5 years ago

Fixes #54 cc @joneshf

Compactable typeclass
fromSeparate -- default compact
fromCompact -- defaults separate
Added combinators

Notes:

I should probably add documentation (definitely)
I feel like there's some very repetitive patterns happening in the map, ap, bind, traverse functions. @sellout you probably have some tricks here :stuck_out_tongue:

FintanH commented 5 years ago

@sellout I don't think that's the CI issue.

# Blocked due to plan-no-credits-available Please purchase a new credit block then push a new commit or call the API to run a new build.

Looks like we don't have credits for this?

sellout commented 5 years ago

Ah, well the previous failure was due to no CI config. This new one seems … wrong. This is an OSS project, I thought those wouldn’t require “credits”?

FintanH commented 5 years ago

Yeh I've no idea, should we ask ops?

sellout commented 5 years ago

Ah crap … apparently I left a ton of comments on an old commit sigh.

sellout commented 5 years ago

I guess like two of my comments are still valid 🤷🏼‍♂️