search

FormerLurker / ArcWelderLib

A collection of projects used to convert G0/G1 commands to G2/G3 commands.
365 stars 39 forks source link

`default_xyz_precision` and `default_e_precision` set to 6 if specified #72

Open fieldOfView opened 3 years ago

fieldOfView commented 3 years ago

Specifying the --default_xyz_precision or --default_e_precision options always results in a value of 6 being used.

In https://github.com/FormerLurker/ArcWelderLib/blob/master/ArcWelderConsole/ArcWelderConsole.cpp#L135 and https://github.com/FormerLurker/ArcWelderLib/blob/master/ArcWelderConsole/ArcWelderConsole.cpp#L141, the --default_xyz_precision or --default_e_precision options are defined as unsigned char, so they are parsed as (ascii) characters instead of ints. In my understanding this means that specifying a 0 will result in a value of 48 being parsed.

FormerLurker commented 3 years ago

Will check this out today, thanks for reporting!

FormerLurker commented 3 years ago

You are 100% correct. And there were more issues hiding in there. I just made a ton of changes, and have been testing almost exclusively via the OctoPrint app. I'm working on some of the other stuff now, and will post back once this is resolved.

FormerLurker commented 3 years ago

Ok, I just pushed a fix to devel. I've got more testing to do, but I think this issue is solved.