search

FormerLurker / ArcWelderPlugin

A plugin for OctoPrint used to convert G0/G1 commands to G2/G3 commands. Reduce the size of your gcode files, and reduce number of gcodes per second sent to your printer.
Other
444 stars 26 forks source link

Removes thumbnail #177

Open TheCableGuy99 opened 3 years ago

TheCableGuy99 commented 3 years ago

Hi,

I've been scratching my head trying to work out why my thumbnails generated by Cura were not working with Octodash.

It appears ArcWelder removes this when processing the file.

Is there any way I can stop it removing the thumbnail?

Thanks for your help.

primeinc commented 3 years ago

This was fixed in 103ad7d63de2c2cc76803ef7ad1e7a58abd79df1 which I believe should be apart of 1.1.0rc2

TheCableGuy99 commented 3 years ago

Sorry for the delay, just been very busy...

I've re-installed and it's reporting my version is: (1.0.0+u.bb71e8f)

Sounds like I have an older version, how can I install a more recent version please? I'm simply searching the plugins within Octoprint and installing it that way.

Thanks.

seantapscott commented 3 years ago

Hi Daskew78,

Looks like there are instructions for changing your release channel for Octoprint in the Readme file on ArcWelder's page. https://github.com/FormerLurker/ArcWelderPlugin

Sean

On Tue, Mar 16, 2021 at 7:31 PM Daskew78 @.***> wrote:

Sorry for the delay, just been very busy...

I've re-installed and it's reporting my version is: (1.0.0+u.bb71e8f)

Sounds like I have an older version, how can I install a more recent version please? I'm simply searching the plugins within Octoprint and installing it that way.

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FormerLurker/ArcWelderPlugin/issues/177#issuecomment-800680470, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5J4UGLACU7ARKMAGLSYSLTD7S5JANCNFSM4ZELBJ4Q .

TheCableGuy99 commented 3 years ago

Hi Daskew78, Looks like there are instructions for changing your release channel for Octoprint in the Readme file on ArcWelder's page. https://github.com/FormerLurker/ArcWelderPlugin Sean … On Tue, Mar 16, 2021 at 7:31 PM Daskew78 @.***> wrote: Sorry for the delay, just been very busy... I've re-installed and it's reporting my version is: (1.0.0+u.bb71e8f) Sounds like I have an older version, how can I install a more recent version please? I'm simply searching the plugins within Octoprint and installing it that way. Thanks. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#177 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5J4UGLACU7ARKMAGLSYSLTD7S5JANCNFSM4ZELBJ4Q .

Thanks, i'm new to Github so didn't notice that. I've managed to install the latest version now. Cheers.

seantapscott commented 3 years ago

No worries, we're all new at some times. FormerLurker has put together a beautiful readme page, and updates it regularly.

On Tue, Mar 16, 2021 at 8:37 PM Daskew78 @.***> wrote:

Hi Daskew78, Looks like there are instructions for changing your release channel for Octoprint in the Readme file on ArcWelder's page. https://github.com/FormerLurker/ArcWelderPlugin Sean … <#m-2991273214193129748> On Tue, Mar 16, 2021 at 7:31 PM Daskew78 @.***> wrote: Sorry for the delay, just been very busy... I've re-installed and it's reporting my version is: (1.0.0+u.bb71e8f) Sounds like I have an older version, how can I install a more recent version please? I'm simply searching the plugins within Octoprint and installing it that way. Thanks. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#177 (comment) https://github.com/FormerLurker/ArcWelderPlugin/issues/177#issuecomment-800680470>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5J4UGLACU7ARKMAGLSYSLTD7S5JANCNFSM4ZELBJ4Q .

Thanks, i'm new to Github so didn't notice that. I've managed to install the latest version now. Cheers.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FormerLurker/ArcWelderPlugin/issues/177#issuecomment-800706888, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5J4UHPL4VUV2HM3HYISH3TD72VDANCNFSM4ZELBJ4Q .

TheCableGuy99 commented 3 years ago

I'll keep an eye on it, thanks again!

FormerLurker commented 3 years ago

@seantapscott, you are a hero! Thank you for your continued contributions, they are super helpful and appreciated!

seantapscott commented 3 years ago

They are a small help, but I hope you see my recognition of your hard work and my good intention of giving you more time. First level support, if I can provide it.

On Tue, Mar 16, 2021 at 9:04 PM FormerLurker @.***> wrote:

@seantapscott https://github.com/seantapscott, you are a hero! Thank you for your continued contributions, they are super helpful and appreciated!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FormerLurker/ArcWelderPlugin/issues/177#issuecomment-800716215, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5J4UA24VH2PYLKV6ZRVCDTD752PANCNFSM4ZELBJ4Q .

soostdijck commented 3 years ago

Came here looking at the same issue, for me is seems to sometimes delete the (cura) thumbnail but not always... Sadly installing the RC with the fix is blocked by #174

Here's to hoping for a real release soon!

FormerLurker commented 3 years ago

@soostdijck, can easily install by using the from url... box in the plugin manager. Let me know if you're interested since I'll be looking for testers soon.

soostdijck commented 3 years ago

Sure I'll test it when the time comes

soostdijck commented 3 years ago

@soostdijck, can easily install by using the from url... box in the plugin manager. Let me know if you're interested since I'll be looking for testers soon.

How it the release going? I'm still missing my thumbnails :(

scottmudge commented 3 years ago

Does https://github.com/FormerLurker/ArcWelderPlugin/commit/103ad7d63de2c2cc76803ef7ad1e7a58abd79df1 also fix the issue with PrusaSlicer thumbnails being removed? I installed the latest RC of 1.1.0, but the thumbnails are still removed.

If it's only compatible with Cura thumbnails, I'll go ahead and create a PR for a fix for PrusaSlicer thumbnails as well. Just want to make sure I'm not fixing something that's already fixed.

notfixingit3 commented 3 years ago

I am also having random issues with some thumbnails from PrusaSlicer being removed.

jneilliii commented 3 years ago

Does 103ad7d also fix the issue with PrusaSlicer thumbnails being removed? I installed the latest RC of 1.1.0, but the thumbnails are still removed.

If it's only compatible with Cura thumbnails, I'll go ahead and create a PR for a fix for PrusaSlicer thumbnails as well. Just want to make sure I'm not fixing something that's already fixed.

Based on what I'm seeing in that commit I think it is accounting for Slicer Thumbnails too.

ManuelMcLure commented 3 years ago

With 1.1.0rc2 it mostly works. However, sometimes (maybe 20% of the time) when AW automatically welds a file uploaded from SuperSlicer the thumbnail doesn't appear. Usually if I delete the welded file and use the button to re-weld the newly welded file will have the thumbnail as expected.

CBDesignS commented 2 years ago

I am on 1.1.0rc4 and have noticed this now and again that the thumbnail is removed & I am sure the code for the thumbnail is still in the gcode file. Usually I have to delete the file, restart octo and then re upload the file and weld it & its good. Today It just refuses to play ball and it removes the thumbnail on every file I try to upload and arcweld.

jneilliii commented 2 years ago

are you able to rescan the files from the slicer thumbnails plugin's settings?

CBDesignS commented 2 years ago

@jneilliii I have just started an 10hr print so do not want to upset the apple cart at the moment + I am fighting/testing a fix for a Marlin thermal protection bug that strikes randomly so as soon as the print completes or the bug wipes me out I will check. I also did just update to 1.7.3 to see if that may have fixed anything but its still the same.

CBDesignS commented 2 years ago

Print completed and no thermal bug. yee. @jneilliii running a rescan in the slicer settings brung the missing thumbnail back. thx I will keep my eye open if they start going missing again. I ssh`d in and checked to see if the plugin had saved the png file and it did so dunno what is slightly wonky....

jneilliii commented 2 years ago

could just be some race condition with the file list not getting updated. I have a request to re scan when pressing the file list refresh button I'm considering implementing this weekend. doesn't solve the problem, but could make it a little easier to rescan.