search

FormerLurker / ArcWelderPlugin

A plugin for OctoPrint used to convert G0/G1 commands to G2/G3 commands. Reduce the size of your gcode files, and reduce number of gcodes per second sent to your printer.
Other
444 stars 26 forks source link

Arc Welder setting 'G90/G91 Influences Extruder' #185

Open b-morgan opened 3 years ago

b-morgan commented 3 years ago

I get the following error message with Arc Welder v1.1.0rc2:

Your firmware requires the 'G90/G91 Influences Extruder' setting to be ENABLED, but it is disabled. Edit the Arc Welder settings, enable the G90/G91 Influences Extruder setting, and run the firmware check again.

I can't find this setting in Arc Welder but the documentation on https://awesomeopensource.com/project/FormerLurker/ArcWelderPlugin:

Arc Welder needs to know one property of your printer's firmware to guarantee accurate results in all slicers and with all start/end GCode: G90/G91 influences extruder.

  • Use Octoprint Settings - Octoprint has a setting for G90/G91 influences extruder in the Features tab. Enabling Use Octoprint Printer Settings will cause Arc Welder to use OctoPrint's setting. Default: Enabled

  • G90/G91 Influence Extruder - If Use Octoprint Feature Settings is unchecked, Arc Welder will use this setting to determine if the G90/G91 command influences your extruder's axis mode. In general, Marlin 2.0 and forks should have this box checked. Many forks of Marlin 1.x should have this unchecked, like the Prusa MK2 and MK3. I will try to add a list of printers and the proper value for this setting at some point, as well as a GCode test script you can use to determine what setting to use. Keep in mind that most slicers produce code that will work fine no matter what setting you choose here. Default: Disabled

I believe the error message should be changed (conditioned) depending on the setting of Use OctoPrint Settings

OctoPi 0.18.0, OctoPrint 1.6.0rc1

FormerLurker commented 3 years ago

Ok, I'll try making the error message more clear, thanks!

FormerLurker commented 3 years ago

Actually, maybe instead of hiding g90/G91 influences extruder, I can show it under the 'Use Octoprint Settings' check box, but gray it out so that it is obviously dependent on 'Use OctoPrint Settings'? Maybe I could do both even...

b-morgan commented 3 years ago

I like the idea of showing it but grayed out but if you do show it under the 'Use OctoPrint Settings', it should reflect the state of the OctoPrint setting.

FormerLurker commented 3 years ago

'Use OctoPrint Settings', it should reflect the state of the OctoPrint setting.

So maybe I can just add some verbiage, like Use Octoprint Settings - G91 Influences Extruder = True or something like that?

b-morgan commented 3 years ago

If I uncheck 'Use OctoPrint Settings' then there are two checkboxes, one for 'Use OctoPrint Settings' and one for 'G90/G91 Influence Extruder'. I think the following will work.

For the error message, 'Edit the Arc Welder setting, ...' changes to 'Edit the Octoprint Feature setting, ...' (note the change from settings to setting) depending on which setting is actually being used.

I think this should reduce the confusion while putting the information in one place.

FormerLurker commented 3 years ago

When the 'Use OctoPrint Settings' checkbox is unchecked, then ungray the 'G90/G91...' and the checkbox reflects the Arc Welder state.

That's perfect, will implement, thanks!

FormerLurker commented 3 years ago

I finally got around to implementing this. I'm working on plugin issues and features now that some major core algorithm fixes and enhancements are complete. Thanks for the suggestion!

FormerLurker commented 3 years ago

I spoke too soon, forgot about the error notification message. Will post back when that's fixed.

FormerLurker commented 3 years ago

OK, I think that is fixed too. Will do some testing over the next day or two. The changes are on the devel branch.