Classic GCode Triggers NOT case insensitive

CmdrCody51 commented 4 years ago

If this is a feature request describe it here

_REPLACE_THISFEATURE_REQUEST_DESCRIPTION_GOES_HERE

Version of Octolapse

Octolapse Version: 0.4.0

Version of OctoPrint

OctoPrint Version: 1.4.0

When you ran into the problem, did you have diagnostic logging enabled?

Diagnostic Logging was Enabled: No

What were you doing when the problem occurred

Just trying to get OctoLapse to run again after upgrade to Buster and Python3.7
Finally got it configured to run and noticed as in images 'snap' !== 'SNAP'

What should have happened?

OctoLapse should have 'swallowed' the trigger word.

What happened instead?

OctoLapse allowed to go to the printer. Also I noticed I now have 3 Triggers in the Trigger state display and two of them are SNAP...

Operating System running OctoPrint and Octolapse

OS Name: Raspbian Os Version: Buster

Printer model & used firmware incl. version

Printer Model: ANET A8 V1.2 motherboard Printer Firmware Version: Marlin V2.0.5.3

Browser and version of browser, operating system running browser

Browser: _REPLACE_THISBROWSER_VERSION_GOES_HERE Browser OS: _REPLACE_THISBROWSER_OS_GOES_HERE

Link to contents of Javascript console in the browser

Link to javascript console output: _REPLACE_THISLINK_GOES_HERE

Screenshots and/or videos of the problem:

Screenshot/Video Links: Screenshot from 2020-08-01 16-16-21

Please consider becoming a patron

If you like this project, please support my work by becoming a patron, and consider adding a 'star' to the repository. It takes a lot of time and effort to maintain the project and respond to issues. The cost of test prints, software, cameras, printer parts, etc. can quickly add up, so every bit helps.

You can find various videos and tutorials by subscribing to my Youtube channel. You can also follow me on Twitter.

FormerLurker commented 4 years ago

Sending gcode from the terminal will not trigger Octolapse, sorry.

CmdrCody51 commented 4 years ago

Sending gcode from the terminal will not trigger Octolapse, sorry.

Then why are the other two blocked like OctoLapse says it does but not the lower case? I didn't expect it to trigger.

FormerLurker commented 4 years ago

Hmm, not sure I understand what you mean. The first command (@Octolapse) will never be sent to the printer. Octoprint prevents anything starting with @ from being sent. Snap was sent, but was not recognized by the printer, which is expected since it is not gcode.

What were you expecting? Also, if you are just testing, use the smart gcode trigger, add your snap or @octolapse commands to your gcode file, and start a print to see the preview. Octolapse will allow you to continue or to abort the print if you dont like what you see.

Does that make sense and answer your question? Have you read the getting started guide?

CmdrCody51 commented 4 years ago

Hmm, not sure I understand what you mean. The first command (@Octolapse) will never be sent to the printer. Octoprint prevents anything starting with @ from being sent. Snap was sent, but was not recognized by the printer, which is expected since it is not gcode.

What were you expecting? Also, if you are just testing, use the smart gcode trigger, add your snap or @octolapse commands to your gcode file, and start a print to see the preview. Octolapse will allow you to continue or to abort the print if you dont like what you see.

Does that make sense and answer your question? Have you read the getting started guide?

If you will examine the image, the first command is "SNAP". The second "@OCTOLAPSE TAKE-SNAPSHOT", The third is a lower case "snap". Quoting your help bubble in Alternative Snapshot Commands -- "Snapshot commands are NOT case sensitive in Octolapse V0.4+. Please note that all comments are stripped from the alternative snapshot command while Octolapse is running."

Now - OctoLapse when running a print (even in test mode) will accept "snap" as a trigger. And then send it right on to the printer.

So why does it do that?

I don't know. Sounds like a bug.

Yes I have read the getting starting guide......

FormerLurker commented 4 years ago

I just didn't understand what it was you were showing with your demonstration. I will take a look.

FormerLurker / Octolapse