Print preview omitting Y and Z components of snapshot planned positions

tech2077 commented 3 years ago

Version of Octolapse

Octolapse Version: 0.4.1

Version of OctoPrint

OctoPrint Version: 1.5.2

When you ran into the problem, did you have diagnostic logging enabled?

Diagnostic Logging was Enabled: NO

What were you doing when the problem occurred

Install OctoLapse
Setup printer profile
Select a smart trigger
Start print with print plan enabled
Print plan preview modal opens

What should have happened?

Coordinates for each snapshot should be displayed with X, Y, and Z components

What happened instead?

Only the X component of the position is displayed

Operating System running OctoPrint and Octolapse

OS Name: Linux (OctoPi) Os Version: 0.17.0 (Python 3)

Browser and version of browser, operating system running browser

Browser: All (tested with latest Firefox, Chrome, and Safari) Browser OS: MacOS

Link to the gcode file you were printing when the problem occurred

Link to Gcode File: Occurs on all gcode

Screenshots and/or videos of the problem:

Screenshot/Video Links:

Please consider becoming a patron

If you like this project, please support my work by becoming a patron, and consider adding a 'star' to the repository. It takes a lot of time and effort to maintain the project and respond to issues. The cost of test prints, software, cameras, printer parts, etc. can quickly add up, so every bit helps.

You can find various videos and tutorials by subscribing to my Youtube channel. You can also follow me on Twitter.

tech2077 commented 3 years ago

Not sure if it's rendering correctly on other systems, but the solution for me appears to be to change the span tags from self closed to a regular tag in templates/octolapse_snapshot_plan.jinja2. I can't find any documentation on the behavior of non-typical self closed tags specific to jinja, but I suspect it's an HTML vs XHTML spec thing.

<strong>Planned Positions</strong>
            <div class="row-fluid">
                <div class="span3 text-right no-min-height">
                    Initial:&nbsp;
                </div>
                <div class="span9 text-left no-min-height">
                    <strong>X</strong><span data-bind="text: SnapshotPlanState.format_coordinates(SnapshotPlanState.x_initial())" />,&nbsp;<strong>Y</strong><span data-bind="text: SnapshotPlanState.format_coordinates(SnapshotPlanState.y_initial())" />,&nbsp;<strong>Z</strong><span data-bind="text: SnapshotPlanState.format_coordinates(SnapshotPlanState.z_initial())" />
                </div>
            </div>

to

<strong>Planned Positions</strong>
            <div class="row-fluid">
                <div class="span3 text-right no-min-height">
                    Initial:&nbsp;
                </div>
                <div class="span9 text-left no-min-height">
                    <strong>X</strong><span data-bind="text: SnapshotPlanState.format_coordinates(SnapshotPlanState.x_initial())"></span>,&nbsp;<strong>Y</strong><span data-bind="text: SnapshotPlanState.format_coordinates(SnapshotPlanState.y_initial())"></span>,&nbsp;<strong>Z</strong><span data-bind="text: SnapshotPlanState.format_coordinates(SnapshotPlanState.z_initial())"></span>
                </div>
            </div>

Screenshot with line changed:

FormerLurker commented 3 years ago

Ok, I think I have solved this. Can you try installing from this link: https://github.com/FormerLurker/Octolapse/archive/b83eb91437be825a1eb14a31c65fadb4d2859513.zip

Let me know if that solves it, and thanks for reporting!

tech2077 commented 3 years ago

Looks like that fixed it. Only notes is there's an extra space before each comma on the "Initial" row:

FormerLurker commented 3 years ago

Another good catch. Will fix that asap

FormerLurker commented 3 years ago

OK, this should be fixed:

Installation url here: https://github.com/FormerLurker/Octolapse/archive/8cae0c9d8f9b11d7a55c3d6fb04956931636429c.zip

Hopefully I got everything this time :)

tech2077 commented 3 years ago

Sorry for the late response, but it's working great now and that fixed the formatting

FormerLurker commented 3 years ago

Man, i have to thank you for closing this out and getting back to me. Rare gem indeed!

FormerLurker / Octolapse