search

FormerLurker / Octolapse

Stabilized timelapses for Octoprint
GNU Affero General Public License v3.0
639 stars 99 forks source link

Add timelapse preview to file browser #669

Open ssendev opened 3 years ago

ssendev commented 3 years ago

Implementation copied from

https://github.com/OctoPrint/OctoPrint/blob/f67c15a9a47794a68be9aed4f2d5a12a87e70179/src/octoprint/static/js/app/viewmodels/timelapse.js#L308-L318

https://github.com/OctoPrint/OctoPrint/blob/f67c15a9a47794a68be9aed4f2d5a12a87e70179/src/octoprint/templates/dialogs/timelapse.jinja2

There were some access checks in the original file browser which the download in Octolapse didn't have so i didn't add one to the preview

also there were quite some variations for function() { so i choose my preferred style

FormerLurker commented 3 years ago

Cool! I will check this out asap.

FormerLurker commented 3 years ago

Question: What formats does the player support? I see you have reused the OctoPrint player template, which isn't working for the default video type for me (.mp4) for some reason.

ssendev commented 3 years ago

It depends on your browser H264 is supported by most

mawoka-myblock commented 2 years ago

It depends on your browser H264 is supported by most

https://caniuse.com/mpeg4

FormerLurker commented 2 years ago

I'm going to reexamine this PR ASAP. Working on a new release, so it's a good time!