search

FormerLurker / Octolapse

Stabilized timelapses for Octoprint
GNU Affero General Public License v3.0
634 stars 99 forks source link

[BUG] Octolapse mistakenly enables vase mode #811

Open Triodes opened 2 years ago

Triodes commented 2 years ago

Bug description

Octolapse mistakenly thinks "vase mode" is enabled because not all cura related settings to this mode are taken into account. For "vase mode" both magic_spiralize and smooth_spiralized_contours should be true, but octolapse only considers the smooth_spiralized_contours which is true by default in cura 4.13, but only comes into effect if magic_spiralize is also true.

Version of Octolapse

Octolapse Version: 0.4.1

Version of OctoPrint

OctoPrint Version: 1.7.2

When you ran into the problem, did you have diagnostic logging enabled?

Diagnostic Logging was Enabled: no

What were you doing when the problem occurred

  1. Select a smart trigger
  2. Start a print
  3. Check the print plan
  4. Notice only ~100 snapshots whereas ~150 layers (350 and 700 respectively for another gcode file I tried)
  5. Mess with settings, no cigar
  6. Manually configure slicer settings, notice that the current settings are likely based on the last gcode file analysed
  7. Notice spiralized contours are on
  8. Check gcode file -> smooth_spiralized_contours == true
  9. Turn spiralized contours off
  10. Now ~150 snapshots
  11. check cura variables reference -> vase mode is a combination of 2 settings: magic_spiralize & smooth_spiralized_contours. smooth_spiralized_contours only takes effect if magic_spiralize is also true, but magic_spiralize is false in my profile.
  12. Deduce that octolapse likely thought I was using vase mode because it only looks at smooth_spiralized_contours instead of looking at magic_spiralize first.

What should have happened?

OctoLapse should only consider "vase mode" enabled if both magic_spiralize and smooth_spiralized_contours are true

What happened instead?

OctoLapse only looks at smooth_spiralized_contours and falsely thinks the print uses vase mode

Operating System running OctoPrint and Octolapse

OS Name: OctoPi Os Version: 0.18.0

Browser and version of browser, operating system running browser

Browser: Chrome 97 Browser OS: Windows 10 21H1

All in one file with logs, gcode and settings octolapse-debug.zip

See this variable reference for more info: http://files.fieldofview.com/cura/Replacement_Patterns.html

FormerLurker commented 2 years ago

Thanks for letting me know about this. I'll take a look at this. So sorry for the delay.