search

FormerLurker / Octolapse

Stabilized timelapses for Octoprint
GNU Affero General Public License v3.0
638 stars 99 forks source link

Octolapse only searches 1000 gcode lines, which fails with thumbnails #856

Open ondrejch opened 2 years ago

ondrejch commented 2 years ago

When the thumbnail gcode is over 1000 lines, octolapse cannot detect the automatic settings provided by Cura. Maybe it should skip thumbnails before looking for the settings in gcode?

BalooDK commented 2 years ago

I decreased my thumbnail size for this same reason You can also put the script in your end gcode

ondrejch commented 2 years ago

I just patched the code, so it scans the whole GCODE file.

TrainAss commented 2 years ago

@ondrejch how did you patch the code?

ondrejch commented 2 years ago

Just increased the line limit.

TrainAss commented 2 years ago

I'm not sure how to do that, sorry.

ondrejch commented 2 years ago

Change the number in settings.py, lines with search_direction="both", max_forward_search=1000, max_reverse_search=1000

In my case: cura_preprocessor = settings_preprocessor.CuraSettingsProcessor( search_direction="both", max_forward_search=100000, max_reverse_search=1000 )

TrainAss commented 2 years ago

Awesome, thank you very much!

vaderag commented 1 year ago

I presume this is the same issue I just saw - I only just enabled thumbnails and the moment I tried to print I got an error...