search

FormidableLabs / appr

Open React Native PR Builds instantly on device
MIT License
381 stars 38 forks source link

Travis instructions for "only PRs" #1

Closed ryan-roemer closed 7 years ago

ryan-roemer commented 7 years ago

As an additional / optional config this section: https://github.com/FormidableLabs/appr#add-travisyml-to-your-project I thought the recommendation for "only PRs + master" was more canonically:

branches:
  only:
    - master
jevakallio commented 7 years ago

I don't want to limit the review apps to pull requests that only target master. And even with this setup, we'd still need the $TRAVIS_PULL_REQUEST check to make sure we are not releasing on master builds.

FWIW the solution used in appr is also recommended in the Travis docs: https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions