search

FormidableLabs / babel-plugin-transform-define

Compile time code replacement for babel similar to Webpack's DefinePlugin
MIT License
245 stars 31 forks source link

Deprecate it #44

Closed steida closed 6 years ago

steida commented 6 years ago

I suppose this is a way to go https://github.com/zeit/next.js/tree/canary/examples/with-dotenv

steida commented 6 years ago

The reason is, having things in json file is risky and confusing.

smeijer commented 6 years ago

Bad idea, they serve different purposes. A version number should be embedded upon build, while api-keys, for example, should come from ENV keys.

transform-define and dotenv can and should live next to each other.