search

FormidableLabs / babel-plugin-transform-define

Compile time code replacement for babel similar to Webpack's DefinePlugin
MIT License
245 stars 31 forks source link

Fix for babel 7 #49

Closed xcarpentier closed 5 years ago

romuloalves commented 6 years ago

Is there any ETA for this merge? Next.js is already using Babel 7 and I can't upgrade my project because of this issue... 😞

imekachi commented 5 years ago

Any progress on this?

webern commented 5 years ago

I have this issue. Is transform-define compatible with Babel 7? Was this fixed somewhere else? Looking...

ryan-roemer commented 5 years ago

Hi folks! 👋

I'm picking up @xcarpentier 's excellent work with some infrastructure stuff we've updated in master in https://github.com/FormidableLabs/babel-plugin-transform-define/compare/chore/babel7 which I'll hope to have up by sometime next week.

We'd ❤️ to have some of the folks here review and kick the tires on that work when it's up!

ryan-roemer commented 5 years ago

We've superseded this PR with https://github.com/FormidableLabs/babel-plugin-transform-define/pull/57 for full babel7 support with a different approach for dynamic configurations of leaving it to babel7 .babelrc.js and babel.config.js loading and execution semantics (environment vars, etc.).

Would love to see if this meets everyone's use cases!