search

FormidableLabs / babel-plugin-transform-define

Compile time code replacement for babel similar to Webpack's DefinePlugin
MIT License
245 stars 31 forks source link

Add support to ppc64le #63

Closed gururajrkatti closed 3 years ago

gururajrkatti commented 3 years ago

This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro on that architecture as well and detecting (and fixing) any issues or failures early would help to ensure that we are always up to date

ryan-roemer commented 3 years ago

While we love matrix builds, can you give me a little more insights as to how a different processor architecture might affect this babel plugin which pretty much does straight parsing in an encapsulated JS engine? (Different OS testing on Windows may make sense, but for a project that does nothing at the byte / processor level, I can't see how something that passed on amd64 would ever fail on ppc64le and vice versa). Thanks!

gururajrkatti commented 3 years ago

Hi @ryan-roemer, thanks for feedback. I understand babel plugins are arch independent. Closing this PR.