FormidableLabs / babel-plugin-transform-define

Compile time code replacement for babel similar to Webpack's DefinePlugin
MIT License
245 stars 31 forks source link

Improve support for import identifiers, fixes #69 #70

Closed jdlm-stripe closed 3 years ago

jdlm-stripe commented 3 years ago

This PR fixes #69 by returning early during identifier traversal if it matches an ES module default or named import. I'm open to feedback if there's anything you think I missed!

ryan-roemer commented 3 years ago

Thanks for this! We'll look into this one probably next week? (I'm on PTO)

jdlm-stripe commented 3 years ago

Sounds good! Thanks for the response :)

ryan-roemer commented 3 years ago

Released in babel-plugin-transform-define@2.0.1. Thanks @jdlm-stripe !