search

FormidableLabs / babel-plugin-transform-define

Compile time code replacement for babel similar to Webpack's DefinePlugin
MIT License
245 stars 31 forks source link

fix-object-properties #88

Closed Titozzz closed 1 year ago

Titozzz commented 1 year ago

Following #86, I've noticed that replacing object properties should also be prevented to avoid issues.

Before, this would crash:

const test = {};
test.__DEV__; // with __DEV__: false
Titozzz commented 1 year ago

gentle nudge @gksander 😅

gksander commented 1 year ago

@Titozzz will you add a patch changeset record to this with yarn changeset and push that up? With that in place, we can get this merged and released ASAP!

Titozzz commented 1 year ago

@gksander All good, sorry for the delay!

gksander commented 1 year ago

Thanks once again @Titozzz! This change has been released as version 2.1.4.