Closed zachhale closed 8 years ago
Looks great!
If you're a reviewer testing this out, you would run
$ npm i -g builder-init
$ builder-init /FULL/PATH/TO/builder-react-app
Then cd
into the resulting react app and try going through the development instructions.
Looks like you need to add .DS_Store
to the local .gitignore
also.
@zachhale and remove the .DS_Store
files from the branch - sorry I didn't say that before.
@zachhale -- Lots of refactoring from lots of comments from folks!
One other thing you should add to .travis.yml
(the root one for the archetype) is to builder-init
a project from this very archetype and run it's checks like: https://github.com/FormidableLabs/builder-react-component/blob/master/.travis.yml#L35-L58
You'll also need to make this repo public, then I'll enable Travis for it.
Lots of changes have been made! Including but not limited to:
webpack-partial
/cc @baer dependencies
into peerDependencies
bluebird
which was seemingly unnecessarytest
script to test-base
@ryan-roemer, @baer, @per, others: Would love a re-review! (not going to do anything this weekend, but I'll look again Monday)
@baer updated the gitignores, added logger + favicon handling to init'd server and made a little refactor of webpack configs. Please review. :pray:
@baer responded to last round of feedback. Please re-review.
@zachhale -- Looking good for getting in the first iteration! I'd really just like that blurb harmonized, and that's it for me on this round.
Huge thanks again to you and @baer for a whole lotta review :heart:
@ryan-roemer is this clear for merge then? I'd love to get this in and start opening up separate issues if it's good as a v1!
@zachhale -- I'm good if @baer is!
Merge it! If there is more work to be done lets do it in PRs so we can track it.
Nice work Zach!
This is a big one. /cc @coopy @ryan-roemer
builder-init
-able sample app for demonstrating use of all of the abilities of this new archetypebuilder-init sample app
Features
react-router
implementationredux
I tried to simplify the app down to a barebones including the above features inspired by @coopy's example app and in a way that I would want when starting a new react app. There are some features of
converter-react
for bootstrapping through the querystring which I omitted. I also found the middleware model for bootstrapping data confusing for an app that has many routes that require differing bootstrapped data per route.Testing this PR
Once the project is generated, you'll need to npm link to the builder-react-app as well.
Then you can
npm install
in peace!TODO
peerDependencies