FormidableLabs / builder-react-app

A React app archetype for builder
5 stars 4 forks source link

Make sure init'd app can pass tests w/out running `builder run build` #8

Closed zachhale closed 8 years ago

zachhale commented 8 years ago

Right now running test-func tries to read dist/server/stats.json

ryan-roemer commented 8 years ago

Actually need both:

$ builder run build
$ builder run install-dev

to get check to run...

As a first step, maybe just document this?

As a second step, let's see if we can not use stats.json but have func tests use an ephemeral dev server (and maybe they do already?)

zachhale commented 8 years ago

So they were using an ephemeral dev server, but a refactor I did a couple days ago broke recognizing it for functional tests. I have a fix for that.

I'll make sure install-dev is properly documented.