improvement publishr

[boygirl]

cc/ @ryan-roemer does this look right to you?

[ryan-roemer]

@boygirl -- I think you also need something like:

    "publishr": {
      "dependencies": ["^builder"]
    }

@jmcriffey -- Can we get your help / guidance / review on this one? First target repo is: https://github.com/FormidableLabs/victory-core/blob/master/package.json

I think we also may need something analogous to https://github.com/FormidableLabs/publishr/blob/master/.npmignore.publishr too (which will need to live in this archetype). Maybe something like adding:

    "publishr": {
      "dependencies": ["^builder"]
      "files": {
        ".npmignore": "node_modules/builder-victory-component/config/OTHER_DIR?/npmignore.publishr",
        ".someconfig": ".someconfig.publishr"
      }
    }

Target for victory-* repo is:

lib/
dist/
demo/ # Maybe? @boygirl?

But within the above, we need to exclude:

dist/*.map

Also,

Thanks!

[boygirl]

@ryan-roemer I think the publishr dependency swapping needs to go in the individual repos, since it's acting on their package.json. Am I missing something?

[ryan-roemer]

@boygirl -- Good point. Remove here and target victory-*/package.json:devDependencies.

[boygirl]

@ryan-roemer .npmignore in victory-* is already not ignoring dist and lib, and is ignoring dist/*.map. I think I can skip the .npmignore.publishr swapping in this case?

[ryan-roemer]

@boygirl -- That sounds right. 👍

[boygirl]

Alright, I've added a dry-run script and removed builder run clean from postpublish. This is unnecessary now as lib/ and dist/ will be .gitignore'd

@ryan-roemer @jmcriffey good to merge?

[jeffrifwald]

LGTM