Closed ryan-roemer closed 7 years ago
@ryan-roemer I think this is failing linting
@boygirl -- Yep. Fixed.
@ryan-roemer once this goes in, I'd like to do a major version bump on the archetypes. Does that sounds appropriate?
@boygirl -- Yep. Major for archetypes. But fortunately, minor for victory repos.
This PR modernizes the Victory build and offerings. Generally:
es/
directory alongsidelib/
that has ES module export / imports (but everything else babel built) per theredux
model. This model allows webpack2+ to use ESM resolution and enable tree-shaking, while is still backwards compatible with webpack1 which will uselib/
.jsx
since we don't use those anymore./cc @boygirl @chrisbolin
Cross-reference PRs
First, infrastructure:
Second, core:
Third, dependers:
Finally, parent:
Tickets
Implemented / fixed:
Opened / still open:
Bundles
The main goal here is not the victory bundle, but enabling webpack2+ users to get more efficient builds going off the
es/
directory. And with the dedupe plugin being removed in webpack2+, our dev bundle is definitely bigger. But, fortunately, the prod minified bundles aren't that different:Before / webpack1
After / webpack3