FormidableLabs / envy

Node.js Telemetry & Network Viewer
https://envy-webui.vercel.app
MIT License
110 stars 0 forks source link

Cleanup requests that did not receive a response #141

Closed carbonrobot closed 1 year ago

carbonrobot commented 1 year ago

Cleanup requests that did not receive a response by setting the state to TIMEOUT and the HTTP Status to -1.

Since each browser implementation (Fetch, XMLHttp), and each browser (FF, Chrome, etc), and each platform (web, node) all use different timeouts, we choose an arbitrary timeout of 2mins. If the request still responds after that time, the UX will still update itself appropriately.

image

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 776478f98378015d05ffe601caf9f405b6003f29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | -------------- | ----- | | @envyjs/webui | Patch | | @envyjs/apollo | Patch | | @envyjs/core | Patch | | @envyjs/nextjs | Patch | | @envyjs/node | Patch | | @envyjs/web | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kgpax commented 1 year ago

Could the status code be -1 instead, and rather than present that as a status code we just say "TIMEOUT WAITING FOR RESPONSE" in the details?

carbonrobot commented 1 year ago

@kgpax Something like this?

image

Should we use a specific color for the TraceList and a specific color for the Detail status code?

kgpax commented 1 year ago

@kgpax Something like this?

image

Should we use a specific color for the TraceList and a specific color for the Detail status code?

Yeah maybe. Perhaps we can omit -1 from the render. Grey would be my shout for the row/circle colour... or maybe just a 25% opacity of the standard colour?

carbonrobot commented 1 year ago

Updated. New screenshot in PR description