FormidableLabs / envy

Node.js Telemetry & Network Viewer
https://envy-webui.vercel.app
MIT License
109 stars 0 forks source link

Replace react/icons with lucid icons #152

Closed carbonrobot closed 1 year ago

carbonrobot commented 1 year ago

Replace react/icons with lucid icons to match new theme. Slight adjustments to spacing since Lucid has a larger default size.

As a sanity check, here are the bundle sizes before and after showing very little difference

Before

  dist/index.b0687038.css       47.07 KB    2.68s
  dist/index.1f555d4e.js       354.15 KB    4.14s
  dist/main.b7de44a8.js        114.26 KB    3.36s
  dist/index.6c941bbb.js         1.21 KB    3.36s
  dist/index.140cbf17.js       326.76 KB    4.13s
  dist/main.01dfd20d.js        113.79 KB    3.36s
  dist/index.c0ff20ce.js         1.19 KB    3.36s

After

dist\index.8565b792.css       46.45 KB     75ms
dist\index.3ecf8fd1.js       348.97 KB    445ms
dist\main.b7de44a8.js        114.26 KB    227ms
dist\index.b6c9d765.js         1.21 KB    145ms
dist\index.4276f353.js       321.77 KB    411ms
dist\main.01dfd20d.js        113.79 KB    219ms
dist\index.de5fb1ba.js         1.19 KB    141ms
changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 7a7fff1b035a6ba6547849bc768f4a5ea8364f21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | -------------- | ----- | | @envyjs/webui | Patch | | @envyjs/apollo | Patch | | @envyjs/core | Patch | | @envyjs/nextjs | Patch | | @envyjs/node | Patch | | @envyjs/web | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

carbonrobot commented 1 year ago

@carloskelly13 Yeah, we can change that. In my first iteration we used something specifically from Lucide, but we no longer do that so it could just be React.FC