FormidableLabs / freactal

Clean and robust state management for React and React-like libs.
MIT License
1.65k stars 47 forks source link

Enhancement: Add `finalize` effect, triggered on unmount (symmetry with `initialize`) #107

Open agurtovoy opened 5 years ago

agurtovoy commented 5 years ago

The maintainers of this repo require that all pull request submitters adhere to the following:

The maintainers of this repository require you to select the semantic version type that the changes in this pull request represent. Please select one of the following:

maintainerd[bot] commented 5 years ago

maintainerd logging is enabled for this repository.

All actions related to rules and their enforcement will be logged here as a permanent record.


Click to view log...

- `2018-08-21T23:33:31.882Z:b85b485`: The pull request was created - `2018-08-21T23:35:44.458Z:b85b485`: @agurtovoy checked `I have read and will comply with the [contribution guidelines](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md).`. - `2018-08-21T23:35:48.316Z:b85b485`: @agurtovoy checked `All related documentation has been updated to reflect the changes made. _(required)_`. - `2018-08-21T23:36:22.003Z:b85b485`: @agurtovoy checked `I have read and will comply with the [code of conduct](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md).`. - `2018-08-21T23:43:59.494Z:b85b485`: @agurtovoy selected `minor` as the semantic version. - `2018-08-21T23:44:02.777Z:b85b485`: @agurtovoy checked `My commit messages are cleaned up and ready to merge. _(required)_`.

agurtovoy commented 5 years ago

Not sure why maintainerd is complaining about cc4ba78; it does have an empty second line. Maybe an old version of maintainerd (https://github.com/divmain/maintainerd/issues/1?)