Declare react as a peerDependency

FormidableLabs / freactal

Clean and robust state management for React and React-like libs.

MIT License

1.65k stars 46 forks source link

Declare react as a peerDependency #53

Closed everdimension closed 7 years ago

everdimension commented 7 years ago

The two main APIs, provideState and injectState, are Higher Order Components which rely on React.

Therefore react is not just a devDependency of this library, it's needed for this library to operate.

divmain commented 7 years ago

This seems reasonable. However, the version should be set to "^15.5.4", the same as the devDependency. There are changes coming in fiber with React v16 that are not yet guaranteed to work with freactal. If you make that change and squash, I'll merge this in. Thanks!

everdimension commented 7 years ago

Alright, done!