search

FormidableLabs / freactal

Clean and robust state management for React and React-like libs.
MIT License
1.65k stars 46 forks source link

Fix: calls mergeIntoState in SSR example #76

Closed Jascha-Sundaresan closed 6 years ago

Jascha-Sundaresan commented 7 years ago

This fixes issue #75

Nothing was wrong w/ the library. The example just called an update function that was previously defined within the example. That function is referred to as 'mergeIntoState' in the library.

The maintainers of this repo require that all pull request submitters adhere to the following:

The maintainers of this repository require you to select the semantic version type that the changes in this pull request represent. Please select one of the following:

maintainerd[bot] commented 7 years ago

maintainerd logging is enabled for this repository.

All actions related to rules and their enforcement will be logged here as a permanent record.

Click to view log...

- `2017-09-30T06:03:31.336Z:3545888`: The pull request was created - `2017-09-30T06:07:58.941Z:3545888`: @Jascha-Sundaresan checked `I have read and will comply with the [contribution guidelines](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md).`. - `2017-09-30T06:08:00.220Z:3545888`: @Jascha-Sundaresan checked `I have read and will comply with the [code of conduct](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md).`. - `2017-09-30T06:08:06.104Z:3545888`: @Jascha-Sundaresan checked `All related documentation has been updated to reflect the changes made. _(required)_`. - `2017-09-30T06:08:08.139Z:3545888`: @Jascha-Sundaresan checked `My commit messages are cleaned up and ready to merge. _(required)_`. - `2017-09-30T06:08:15.494Z:3545888`: @Jascha-Sundaresan selected `patch` as the semantic version.

ryan-roemer commented 6 years ago

@Jascha-Sundaresan -- Thanks. Looking at this now.

Jascha-Sundaresan commented 6 years ago

@ryan-roemer the babelrc you're commenting on is not the main babelrc which is configured to support browsers. The babelrc you are commenting on is in the spec folder and is only for running specs, which run on node.