search

FormidableLabs / freactal

Clean and robust state management for React and React-like libs.
MIT License
1.65k stars 46 forks source link

Enhancement: Add ES and UMD builds #85

Closed aweary closed 6 years ago

aweary commented 6 years ago

With the UMD build both prop-types and react are expected to be available on the global object before Freactal is loading. Since both of those packages have UMD builds, this should be fine.

The maintainers of this repo require that all pull request submitters adhere to the following:

The maintainers of this repository require you to select the semantic version type that the changes in this pull request represent. Please select one of the following:

maintainerd[bot] commented 6 years ago

maintainerd logging is enabled for this repository.

All actions related to rules and their enforcement will be logged here as a permanent record.

Click to view log...

- `2017-11-30T21:29:18.319Z:4435056`: The pull request was created - `2017-11-30T22:38:44.015Z:f11db1f`: @aweary checked `I have read and will comply with the [contribution guidelines](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md).`. - `2017-11-30T22:38:44.642Z:f11db1f`: @aweary checked `I have read and will comply with the [code of conduct](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md).`. - `2017-11-30T22:38:45.762Z:f11db1f`: @aweary checked `All related documentation has been updated to reflect the changes made. _(required)_`. - `2017-11-30T22:38:46.445Z:f11db1f`: @aweary checked `My commit messages are cleaned up and ready to merge. _(required)_`. - `2017-11-30T22:38:52.051Z:f11db1f`: @aweary selected `documentation only` as the semantic version. - `2017-11-30T22:50:22.385Z:c648aa4`: @aweary selected `patch` as the semantic version. - `2017-11-30T22:50:23.301Z:c648aa4`: @aweary deselected `documentation only` as the semantic version.

aweary commented 6 years ago

@ryan-roemer I've checked all the required boxes and moved prop-types to the peer dependencies.

ryan-roemer commented 6 years ago

Closing in favor of https://github.com/FormidableLabs/freactal/pull/94 -- @aweary thanks for all the great work, I've just move almost entirely what you've got here to there :)