search

FormidableLabs / freactal

Clean and robust state management for React and React-like libs.
MIT License
1.65k stars 46 forks source link

Fix: server-side rendering examples (docs) #89

Closed agurtovoy closed 6 years ago

agurtovoy commented 6 years ago

Making the docs conform to the actual example code.

The maintainers of this repo require that all pull request submitters adhere to the following:

The maintainers of this repository require you to select the semantic version type that the changes in this pull request represent. Please select one of the following:

maintainerd[bot] commented 6 years ago

maintainerd logging is enabled for this repository.

All actions related to rules and their enforcement will be logged here as a permanent record.

Click to view log...

- `2017-12-29T04:21:33.696Z:49fa2b2`: The pull request was created - `2017-12-29T19:09:22.388Z:49fa2b2`: @agurtovoy checked `I have read and will comply with the [contribution guidelines](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md).`. - `2017-12-29T19:09:33.101Z:49fa2b2`: @agurtovoy checked `I have read and will comply with the [code of conduct](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md).`. - `2017-12-29T19:09:36.745Z:49fa2b2`: @agurtovoy checked `All related documentation has been updated to reflect the changes made. _(required)_`. - `2017-12-29T19:09:46.900Z:49fa2b2`: @agurtovoy selected `documentation only` as the semantic version. - `2017-12-29T19:10:32.550Z:49fa2b2`: @agurtovoy checked `My commit messages are cleaned up and ready to merge. _(required)_`.

agurtovoy commented 6 years ago

Not sure why the subject check is failing.

ryan-roemer commented 6 years ago

@agurtovoy -- Yeah, the subject looks like it should match https://github.com/FormidableLabs/freactal/blob/master/.maintainerd#L25-L28 just fine.

@divmain -- Any idea what maintainerd is complaining about? Is there a way to get more information on maintainerd failures in PRs like this?

agurtovoy commented 6 years ago

I'm going to close this PR and resubmit it from a dedicated branch.

New PR: https://github.com/FormidableLabs/freactal/pull/93