FormidableLabs / inspectpack

An inspection tool for Webpack frontend JavaScript bundles.
MIT License
592 stars 20 forks source link

[WIP] BUG: hidden app roots #104

Closed ryan-roemer closed 5 years ago

ryan-roemer commented 5 years ago

When an application root has no actual node_modules in it, the versions action inference fails to find the app root package.json file and misses traversing the versions dependencies. This has the buggy effects of:

Work

Example

The regression fixture displays similar bad output to the original bug #103 :

[Building fixture] ../../test/fixtures/hidden-app-roots/dist-production-4/bundle.js

Hash: ad1c54643fd96dfbb316
Version: webpack 4.6.0
Time: 169ms
Built at: 2019-02-26 11:16:37
     Asset       Size  Chunks             Chunk Names
 bundle.js  874 bytes       0  [emitted]  bundle
stats.json   8.38 KiB          [emitted]  
Entrypoint bundle = bundle.js
[4] ./packages/hidden-app/src/index.js 245 bytes {0} [built]
    + 4 hidden modules

WARNING in Duplicate Sources / Packages - Duplicates found! ⚠️

* Duplicates: Found 2 similar files across 2 code sources (both identical + similar)
  accounting for 118 bundled bytes.
* Packages: Found 0 packages with 0 resolved, 0 installed, and 0 depended versions.

* Understanding the report: Need help with the details? See:
  https://github.com/FormidableLabs/inspectpack/#diagnosing-duplicates
* Fixing bundle duplicates: An introductory guide:
  https://github.com/FormidableLabs/inspectpack/#fixing-bundle-duplicates
ryan-roemer commented 5 years ago

Closing and re-opening to kick new Travis integration.

ryan-roemer commented 5 years ago

Closing and re-opening again to try again to kick Travis post-migration.

ryan-roemer commented 5 years ago

Closing in favor of #107