BUG: hidden app roots (v2)

[ryan-roemer]

Version 2. Supersedes #104

When an application root has no actual node_modules in it, the versions action inference fails to find the app root package.json file and misses traversing the versions dependencies. This has the buggy effects of:

• Missing information in versions action for CLI
• Missing information in DuplicatesPlugin.

Work

• [x] Create regression test fixtures
• [x] Create regression tests
• [x] Create fix. Fixes #103
• [x] Address all TODOs and clean up.

[codecov[bot]]

Codecov Report

Merging #107 into master will increase coverage by 0.18%. The diff coverage is 96.03%.

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   90.77%   90.95%   +0.18%     
==========================================
  Files          14       15       +1     
  Lines         694      730      +36     
  Branches      111      116       +5     
==========================================
+ Hits          630      664      +34     
- Misses         38       39       +1     
- Partials       26       27       +1

Impacted Files	Coverage Δ
src/lib/util/promise.ts	100% <100%> (ø)
src/lib/actions/base.ts	93.2% <100%> (+0.06%)	:arrow_up:
src/lib/util/dependencies.ts	95.13% <92%> (+0.21%)	:arrow_up:
src/lib/actions/versions.ts	94.76% <97.22%> (-0.44%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe5e41f...54c49a5. Read the comment docs.

[codecov[bot]]

Codecov Report

Merging #107 into master will decrease coverage by 0.21%. The diff coverage is 92.7%.

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   90.77%   90.56%   -0.22%     
==========================================
  Files          14       15       +1     
  Lines         694      763      +69     
  Branches      111      122      +11     
==========================================
+ Hits          630      691      +61     
- Misses         38       41       +3     
- Partials       26       31       +5

Impacted Files	Coverage Δ
src/lib/util/promise.ts	100% <100%> (ø)
src/lib/actions/base.ts	93.2% <100%> (+0.06%)	:arrow_up:
src/plugin/duplicates.ts	86.3% <80%> (-1.11%)	:arrow_down:
src/lib/util/dependencies.ts	95.1% <91.66%> (+0.17%)	:arrow_up:
src/lib/actions/versions.ts	94.11% <95.5%> (-1.09%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe5e41f...18bd729. Read the comment docs.

[ryan-roemer]

Released in inspectpack@4.2.0

[parkerziegler]

@ryan-roemer I'm going to upgrade webpack-dashboard to use inspectpack@4.2.0 to pick up this change in 3.0.1. Do you think this fixes https://github.com/FormidableLabs/webpack-dashboard/issues/276?

[ryan-roemer]

@parkerziegler -- Upgrade sounds great! Unfortunately, it won't fix https://github.com/FormidableLabs/webpack-dashboard/issues/276 which I'm likely going to migrate over to inspectpack as an issue there....

[parkerziegler]

Cool, no worries. Thanks a lot for taking that one on, and for this PR!