search

FormidableLabs / inspectpack

An inspection tool for Webpack frontend JavaScript bundles.
MIT License
592 stars 20 forks source link

BUG: Handle circular dependencies recursion issue in `versions`. #130

Closed ryan-roemer closed 4 years ago

ryan-roemer commented 4 years ago

Fixes #128

@dvargas92495 -- If you get a chance, can you pull this branch and try out? Requires a yarn build after yarn install.

codecov[bot] commented 4 years ago

Codecov Report

Merging #130 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   91.94%   92.01%   +0.06%     
==========================================
  Files          13       13              
  Lines         745      751       +6     
  Branches      123      123              
==========================================
+ Hits          685      691       +6     
  Misses         25       25              
  Partials       35       35
Impacted Files Coverage Δ
src/lib/util/dependencies.ts 95.3% <100%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9f5bd6...8b8702f. Read the comment docs.

dvargas92495 commented 4 years ago

it works!

ryan-roemer commented 4 years ago

Released in inspectpack@4.3.1