FormidableLabs / inspectpack

An inspection tool for Webpack frontend JavaScript bundles.
MIT License
591 stars 20 forks source link

Allow CI to pass #179

Open kopax-polyconseil opened 2 years ago

kopax-polyconseil commented 2 years ago

Hello,

I have installed this package in 4.7.1 to keep a track of our duplicates packages, and now the CI fail :

image image

This is our configuration in webpack 4 https://github.com/pass-culture/pass-culture-app-native/blob/c703bd08bf949eba64fe282c97034f09d97a3a57/web/config/webpack.config.js#L722-L738

        new DuplicatesPlugin({
          // Emit compilation warning or error? (Default: `false`)
          emitErrors: false,
          // Handle all messages with handler function (`(report: string)`)
          // Overrides `emitErrors` output.
          emitHandler: undefined,
          // List of packages that can be ignored. (Default: `[]`)
          // - If a string, then a prefix match of `{$name}/` for each module.
          // - If a regex, then `.test(pattern)` which means you should add slashes
          //   where appropriate.
          //
          // **Note**: Uses posix paths for all matching (e.g., on windows `/` not `\`).
          ignoredPackages: undefined,
          // Display full duplicates information? (Default: `false`)
          verbose: true
        })

I would expect emitErrors to prevent the CI to fail.

How can I allow the CI to pass ? Can this be a futur feture ?

Thanks for sharing !

ryan-roemer commented 2 years ago

Can you give me error reproduction steps? I've checked out your repository at: https://github.com/pass-culture/pass-culture-app-native/tree/c703bd08bf949eba64fe282c97034f09d97a3a57

and get this:

$ SHOW_DUPLICATES_PLUGIN=true yarn build:staging
yarn run v1.22.19
$ ENV=staging yarn build
$ SHOW_DUPLICATES_PLUGIN=${SHOW_DUPLICATES_PLUGIN:-true} node web/scripts/build.js
Creating an optimized production build...

Duplicate Sources / Packages - No duplicates found. 🚀

Failed to compile.

Sentry CLI Plugin: Command failed: /Users/rye/scm/vendor/pass-culture-app-native/node_modules/@sentry/cli/sentry-cli releases new 1.201.1-web-c703bd08b
error: An organization slug is required (provide with --org)

Add --log-level=[info|debug] or export SENTRY_LOG_LEVEL=[info|debug] to see more output.
Please attach the full debug log to all bug reports.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

As CI is failing, can you also point me to a failing CircleCI page?