search

FormidableLabs / inspectpack

An inspection tool for Webpack frontend JavaScript bundles.
MIT License
592 stars 20 forks source link

`better-sqlite3` compiles from source #58

Closed wallzero closed 6 years ago

wallzero commented 6 years ago

I was using webpack-dashboard, but since the 1.x.x releases, it appears inspectpack now depends/installs better-sqlite3? better-sqlite3 dependency seems to only include source, and must compile on every npm install. Is there an alternative with prebuilt binaries or can this dependency be omitted somehow? It appears I'm not the only one who requests this.

ryan-roemer commented 6 years ago

better-sqlite3 is an optionalDependencies, so we're not breaking anyone if the install fails.

We'll definitely accept a PR that has prebuilt binaries or something that still gives up sqlite while omitting the build step.

wallzero commented 6 years ago

Thanks! Even if my system can run better-sqlite3 successfully, I just don't want the additional build time. I'd prefer it if the dependency wasn't listed at all, and then the documentation informs users that if they'd like caching, they must include install better-sqlite3 in their package.json.

It boils down to this issue; we can't yet ignore optional dependencies in package.json. If we ever can, then I could ignore webpack-dashboard and inspectpack's optionalDependencies and this wouldn't be an issue.

ryan-roemer commented 6 years ago

Removed library in inspectpack@^3.