search

FormidableLabs / jest-next-dynamic

Resolve Next.js dynamic import components in Jest tests
MIT License
69 stars 7 forks source link

Is this needed anymore with Next 11.1? #34

Open DustinBrett opened 3 years ago

DustinBrett commented 3 years ago

I removed it and it worked without it. Based on seeing this in the release notes:

https://github.com/vercel/next.js/pull/26614

leerob commented 3 years ago

Correct, this library can now be deprecated! Thank you so much to the Formidable team for helping patch this issue in the interim 🙌

DustinBrett commented 2 years ago

I recently needed this again with 12.0.8 of next.js.

buesing commented 1 year ago

@leerob do we have an official info, is this necessary or not from v12 on? Edit: found this issue, but it was closed due to inactivity: https://github.com/vercel/next.js/issues/36647

DustinBrett commented 1 year ago

I've since gone to using next/jest. (https://nextjs.org/docs/testing)

buesing commented 1 year ago

It's still happening though, even with the app from their examples. Made a new issue in next: https://github.com/vercel/next.js/issues/41725

DustinBrett commented 1 year ago

Ah ok darn. I don't even think I do the dynamic import test anymore. Perhaps I gave up.