Closed alexlande closed 10 years ago
@cherimarie this PR is yours to modify and merge in. Going forward you can ask Alex for design help or initial mockups of screens but you can implement and polish the HTML and CSS from there.
@alexlande I implemented your styles throughout. It's looking marvelous. I'm attaching screenshots of admin areas, though, because my design sensibilities actually are terrible and we shouldn't trust them :)
I believe I'm waiting on you for a header design, and maybe footer, plus any suggestions you have about admin areas. Do we really need a footer, from a usability standpoint? I'm not sure what would need to go there. Maybe links to more info about /Dev/Local? Our inspiration, https://weworkremotely.com/ , has nothing but an advertisement in their footer.
@alexlande Styles are all pushed to http://dl-job-board.herokuapp.com/admin, but the "logo as background image" situation in the header doesn't seem to be working. I'm mystified- any ideas?
@cherimarie Not sure. Wonder if it might be some asset pipeline weirdness since it's an SVG? I've occasionally hit issues where servers try to serve SVGs with the wrong MIME type, but they usually just fail to display instead of 404 when that happens. Either way, we should probably just embed the logo in the stylesheet, so it might not matter.
Re: footer, yeah, maybe not. Was thinking we might want a link to DevLocal, maybe to the Twitter + Github accounts. Can always add that kind of thing later though. I'll have some stuff for the header + admin screens soon. Looking awesome!
This adds base CSS and initial designs for listings.
Notes: I added a footer partial because it seems likely that we'll want one but it doesn't have anything in it yet. I also haven't touched the header despite what that first screenshot looks like.
Using Sass + Autoprefixer, no Compass. All of the CSS lives in
app/assets/stylesheets/framework
.@cherimarie: I'm not able to approve listings running this locally, not sure what's up. I get this error:
I made a partial to display listings, but I expect that it isn't working on any page except for the search page (which is what I was using for dev). Can't verify that because of the error.
Not sure what your schedule is like. I'll be working on this over the weekend to get stuff up to speed. If you have time to kill, it would be awesome if you want to start incorporating some of these components into other parts of the site. No problem if not though.
I'm going to start moving on to the header + footer next, then head over to Admin sections, most likely.
/cc @cherimarie @eastridge
Screenshots: