search

FormidableLabs / jobboard

0 stars 2 forks source link

Feature: Add review listing design #25

Closed alexlande closed 10 years ago

alexlande commented 10 years ago

This adds a design for the review listing page. I messed around with doing some custom designs for it, but then it hit me that it might just make sense to show the reviewer the post in context, as a user will see it:

screen shot 2014-03-17 at 11 33 22 am

Thoughts?

/cc @cherimarie @eastridge

eastridge commented 10 years ago

Looks fabulous to me

On Mon, Mar 17, 2014 at 11:35 AM, Alex Lande notifications@github.comwrote:

This adds a design for the review listing page. I messed around with doing some custom designs for it, but then it hit me that it might just make sense to show the reviewer the post in context, as a user will see it:

[image: screen shot 2014-03-17 at 11 33 22 am]https://f.cloud.github.com/assets/808159/2439978/e1f2bc60-ae02-11e3-9d24-e55ff432d1c2.png

Thoughts?

/cc @cherimarie https://github.com/cherimarie @eastridgehttps://github.com/eastridge

You can merge this Pull Request by running

git pull https://github.com/FormidableLabs/jobboard feature-review-design

Or view, comment on, or merge it at:

https://github.com/FormidableLabs/jobboard/pull/25 Commit Summary

  • Add review listing design

File Changes

  • M app/assets/stylesheets/framework/_base.scsshttps://github.com/FormidableLabs/jobboard/pull/25/files#diff-0(18)
  • M app/assets/stylesheets/framework/_components.scsshttps://github.com/FormidableLabs/jobboard/pull/25/files#diff-1(14)
  • M app/assets/stylesheets/framework/_forms.scsshttps://github.com/FormidableLabs/jobboard/pull/25/files#diff-2(10)
  • M app/assets/stylesheets/framework/_utilities.scsshttps://github.com/FormidableLabs/jobboard/pull/25/files#diff-3(8)
  • M app/views/listings/admin_review.html.erbhttps://github.com/FormidableLabs/jobboard/pull/25/files#diff-4(40)
  • M app/views/listings/review.html.erbhttps://github.com/FormidableLabs/jobboard/pull/25/files#diff-5(9)
  • M app/views/listings/show.html.erbhttps://github.com/FormidableLabs/jobboard/pull/25/files#diff-6(32)
  • A app/views/shared/_listing_post.html.erbhttps://github.com/FormidableLabs/jobboard/pull/25/files#diff-7(31)

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com/FormidableLabs/jobboard/pull/25 .

cherimarie commented 10 years ago

Looks great! I transferred the styling over to the submitter_review page, to the best of my abilities. Could you take a look, @alexlande ? screen shot 2014-03-17 at 12 38 31 pm

alexlande commented 10 years ago

Added a fix for that:

screen shot 2014-03-17 at 3 30 09 pm

cherimarie commented 10 years ago

Ha ha! @alexlande , I didn't even see that there was a problem with the columns being different lengths. Thank you! Ok, so I made the live listing review have this same styling, so they should all be beautiful now. Merging.