search

FormidableLabs / nextjs-sanity-fe

NextJS Demo site with Sanity CMS
https://nextjs-sanity.formidable.dev/
29 stars 6 forks source link

chore pnpm v8 #207

Closed nlkluth closed 10 months ago

nlkluth commented 10 months ago

What

Upgrade pnpm to v8

Why

Breakout update to isolate breaking changes

Info

Vercel automatically supports v8 with a 6.0 lockfile https://vercel.com/changelog/automatic-pnpm-v8-support

It seems like we are in a bit of a mixed state between lockfile 6.0 and pnpm@8. Running pnpm i with the latest lockfile won't make any changes, however if you delete the lockfile and run it will generate the new file (as in this PR) with autoInstallPeers: true which is the major change. This is also true if you make any workspaces changes, which is what I am running into.

This is breaking CI which has frozen lockfile settings. My PR was failing due to this change. Downgrading my pnpm was not the answer, and this change to pnpm-lock.yml seems almost unavoidable with the latest pnpm version once you make any change.

Help

We'll need to get around the frozen lockfile as a one-time deal 🤔

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-sanity-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 7:31pm