fix: only include inert property when slide is not in view

[allypalanzi]

Description

Currently, inert is applied to every slide, which is causing issues if slides have interact-able elements on them. When a slide is in view, we are setting inert="false" which is basically still applying the inert property.

Instead we need to not have the inert property at all when the slide is in view.

Fixes #999

Type of Change

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

Verified in Storybook that the active slide does not have inert set

Checklist

• [x] My code follows the style guidelines of this project (I have run pnpm run lint)
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes (I have run pnpm run test:ci-with-server/pnpm run test)
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have recorded any user-facing fixes or changes with pnpm changeset.
• [x] My changes generate no new warnings
• [ ] Any dependent changes have been merged and published in downstream modules

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nuka-carousel	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 14, 2023 at 4:04PM (UTC)

[allypalanzi]

@carlos-kelly would love to get this released so i can finally upgrade to nuka v5 🙏🏻

[Panzki]

Hi, we ran into this problem as well. The HTML spec states that "The inert attribute is a boolean attribute that indicates, by its presence, [...] are to be made inert by the user agent." (see here) Setting inert to false does not disable the inert state of the slide, inert has to be absent. When testing this behavior make sure to not use FireFox, because FireFox does not support inert (yet): https://caniuse.com/?search=inert

The fix looks good to me. I'd welcome an additional regression test. It would be nice if you could rollout the fix soon.

In the meantime we worked around the problem by downgrading the package to version 5.4.1. The bug was introduced in version 5.5.0 (this commit)

[allypalanzi]

unfortunetly i need the fixed width slides in 5.5 😭