FormidableLabs / nuka-carousel

Small, fast, and accessibility-first React carousel library with an easily customizable UI and behavior to fit your brand and site.

https://commerce.nearform.com/open-source/nuka-carousel

Other

3k stars 596 forks source link

Missing ability to set id for use in key value, key uses 'undefined'. #1003

Closed evendaniel closed 2 months ago

evendaniel commented 1 year ago

Bugs and Questions

Prerequisites

[x ] I've searched open issues to make sure I'm not opening a duplicate issue
[x ] I have read through the docs before asking a question
[ x] I am using the latest version of nuka-carousel

Describe Your Environment

What version of nuka-carousel are you using? 5.5.1
What version of React are you using? 18.2.0
What browser are you using? not relevant

Describe the Problem

unable to set key value for Slide. I would imagine I should be able to pass a unique id to use as the key of the Slide element.

Expected behavior:

supply an id to the carousel that is used when generating the key value.

Actual behavior

undefined is used when generating the key value. e.g. 'undefined-2'

carbonrobot commented 2 months ago

In v8, children are controlled and set by the consumer so you can supply any key value needed.