search

FormidableLabs / nuka-carousel

Small, fast, and accessibility-first React carousel library with an easily customizable UI and behavior to fit your brand and site.
https://commerce.nearform.com/open-source/nuka-carousel
Other
3.06k stars 594 forks source link

Remove random page story to prevent chromatic problems #1059

Closed carbonrobot closed 5 months ago

carbonrobot commented 5 months ago

Remove the story in Storybook that set the page to a random index. When this runs in Chromatic, it causes the Chromatic test to fail because its a random number each time. This sets a specific number to avoid that problem while still testing the required functionality.

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 4184caf5d4327d641eff35a4e15e0abb0de5d124

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuka-carousel-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 9:26pm