search

FormidableLabs / nuka-carousel

Small, fast, and accessibility-first React carousel library with an easily customizable UI and behavior to fit your brand and site.
https://commerce.nearform.com/open-source/nuka-carousel
Other
3.08k stars 595 forks source link

React 15.0 support? #70

Closed sompylasar closed 8 years ago

sompylasar commented 8 years ago

It's already RC2: https://facebook.github.io/react/blog/2016/03/16/react-v15-rc2.html

bogas04 commented 8 years ago

And it released today.

kenwheeler commented 8 years ago

Sorry, was on vacation, just got back and merged the compat update. I'll cut a release, just waiting on a rebase on one of the latest PRs

sompylasar commented 8 years ago

@kenwheeler could you please release the react@15 compat?

sompylasar commented 8 years ago

Sadly, the change in #73 is not enough because react-tween-state specifies the peer dependency, too: https://github.com/chenglou/react-tween-state/issues/57 https://github.com/chenglou/react-tween-state/pull/55 When the above is merged, nuka-carousel will have to follow and update, too.

kenwheeler commented 8 years ago

@sompylasar what happens when you try and install master? you get an unmet warning for tween state?

sompylasar commented 8 years ago

@kenwheeler Yes, exactly. And npm@3 refuses to rebuild the shrinkwrap because of that. For now, I've made a fork with a proper dependency: https://github.com/sompylasar/nuka-carousel/commit/a9d871b7c46b9a1a3d7c3f599b5d9d2df3f810c8

kennetpostigo commented 8 years ago

Was this fixed @sompylasar? I'm currently debating to use nuka or react-slick not sure if they support react v15.0 as of yet.

sompylasar commented 8 years ago

@kennetpostigo I use "nuka-carousel": "^1.2.0", with "react": "^15.0.2", without issues.

kennetpostigo commented 8 years ago

Thank you!