FormidableLabs / nuka-carousel

Small, fast, and accessibility-first React carousel library with an easily customizable UI and behavior to fit your brand and site.
https://commerce.nearform.com/open-source/nuka-carousel
Other
3.07k stars 595 forks source link

slider-container has hardCoded padding #852

Closed Amit-Kaplan closed 2 years ago

Amit-Kaplan commented 2 years ago

Bugs and Questions

Prerequisites

Feel free to delete this section if you have checked off all of the following.

Describe Your Environment

Describe the Problem

slider-container has hardCoded padding in case of using visual controls. `<div className={'slider-container'} style={{ position: 'relative', padding: props.withoutControls ? 0 : '0 60px 50px' }} onMouseEnter={onMouseEnter} onMouseLeave={onMouseLeave}

...... `

Expected behavior: padding can be change by props Actual behavior: hard coded

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

ValGeorgiev commented 2 years ago

Hey @Amit-Kaplan thanks for this, I will look to submit a PR today and tomorrow about that.

ValGeorgiev commented 2 years ago

This should be fixed with v5.0.3. Please reopen and let me know if you still have this issue.