search

FormidableLabs / nuka-carousel

Small, fast, and accessibility-first React carousel library with an easily customizable UI and behavior to fit your brand and site.
https://commerce.nearform.com/open-source/nuka-carousel
Other
3.07k stars 595 forks source link

Accessibility bug #859

Closed Konserwa203 closed 2 years ago

Konserwa203 commented 2 years ago

Hi, I'd like to report one accessibility bug:

1) There is a wrong property on paging-items: aria-selected

According to documentation there should be aria-pressed property instead. https://www.levelaccess.com/how-not-to-misuse-aria-states-properties-and-roles/

ValGeorgiev commented 2 years ago

Hi @Konserwa203, thanks for raising this with us. I am not 100% convinced that aria-pressed is the more appropriate property for the paging items. As in the docs is described, aria-selected is This attribute is used to indicate which elements within single-selection and multiple-selection composite widgets are selected. link. While aria-pressed is for toggle buttons only. I know it's a hard call here, happy to hear more arguments.