Add adaptiveHeight to CarouselProps interface

geoffharcourt commented 2 years ago

This change adds adaptiveHeight to CarouselProps to reflect the current implementation.

Fix #881

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # 881

Type of Change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist: (Feel free to delete this section upon completion)

[x] My code follows the style guidelines of this project (I have run yarn lint)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes (I have run yarn test and yarn test-e2e)
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] For any breaking API changes, I have updated the type definitions in index.d.ts
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

yarn lint and yarn test have failures and warnings for me with the current state of main, this change did not add any new warnings or failures.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuka-carousel/nuka-carousel/82sJx7dWPSrqgMvsuKbAB1YX2kh5
✅ Preview: https://nuka-carousel-git-fork-geoffharcourt-gh-ad-bef909-nuka-carousel.vercel.app

geoffharcourt commented 2 years ago

It looks like props are in multiple places. I'm using esbuild and it's bumping into some import issues. Closing this out as it's not the real issue.

FormidableLabs / nuka-carousel