Closed hueldera closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
nuka-carousel | ✅ Ready (Inspect) | Visit Preview | Jun 14, 2022 at 6:17PM (UTC) |
Hey @hueldera, thank you for the PR. Which version of the nuka-carousel are you using?
Hey @hueldera, thank you for the PR. Which version of the nuka-carousel are you using?
Hi @ValGeorgiev, I tested with the main branch (v5.1.1)
Hey @hueldera, thank you for the PR. Which version of the nuka-carousel are you using?
Hi @ValGeorgiev, I tested with the main branch (v5.1.1)
thats weird cause your changes are on the legacy src/ folder which will be deprecated soon. And I am not sure if this will fix the issue.
@ValGeorgiev Sorry, I completely ignored that the versions coexist, so in V5 if you enable touch action, we don't have this error. It turns out that this PR updates the current V4 version, in production I'm still on it for now.
Description
Fix the
[Intervention]Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.
console error when scrolling with touch on mobile.Type of Change
How Has This Been Tested?
height: 200vh
andalign-items: center
to Drag Multiple Slides example in StorybookChecklist: (Feel free to delete this section upon completion)
yarn lint
)yarn test
andyarn test-e2e
)index.d.ts