FormidableLabs / nuka-carousel

Small, fast, and accessibility-first React carousel library with an easily customizable UI and behavior to fit your brand and site.
https://commerce.nearform.com/open-source/nuka-carousel
Other
3.06k stars 593 forks source link

fix: ignored attempt to cancel a touchmove event with cancelable=false #912

Closed hueldera closed 1 year ago

hueldera commented 2 years ago

Description

Fix the [Intervention]Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted. console error when scrolling with touch on mobile.

ezgif-4-ce4c31bb0d

Type of Change

How Has This Been Tested?

ezgif-4-ad5b34989d

Checklist: (Feel free to delete this section upon completion)

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nuka-carousel ✅ Ready (Inspect) Visit Preview Jun 14, 2022 at 6:17PM (UTC)
ValGeorgiev commented 2 years ago

Hey @hueldera, thank you for the PR. Which version of the nuka-carousel are you using?

hueldera commented 2 years ago

Hey @hueldera, thank you for the PR. Which version of the nuka-carousel are you using?

Hi @ValGeorgiev, I tested with the main branch (v5.1.1)

ValGeorgiev commented 2 years ago

Hey @hueldera, thank you for the PR. Which version of the nuka-carousel are you using?

Hi @ValGeorgiev, I tested with the main branch (v5.1.1)

thats weird cause your changes are on the legacy src/ folder which will be deprecated soon. And I am not sure if this will fix the issue.

hueldera commented 2 years ago

@ValGeorgiev Sorry, I completely ignored that the versions coexist, so in V5 if you enable touch action, we don't have this error. It turns out that this PR updates the current V4 version, in production I'm still on it for now.